From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbdFWU1Y (ORCPT ); Fri, 23 Jun 2017 16:27:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47218 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755155AbdFWU1V (ORCPT ); Fri, 23 Jun 2017 16:27:21 -0400 Date: Sat, 24 Jun 2017 00:34:41 +0800 From: Greg KH To: Derek Robson Cc: arnd@arndb.de, binoy.jayan@linaro.org, singhalsimran0@gmail.com, karniksayli1995@gmail.com, yamada.masahiro@socionext.com, salah.triki@acm.org, colin.king@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] staging: rtl8192u: style fix Message-ID: <20170623163441.GB25815@kroah.com> References: <20170617032632.15122-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170617032632.15122-1-robsonde@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 17, 2017 at 03:26:32PM +1200, Derek Robson wrote: > Fixed checkpatch.pl warnings of "function definition argument FOO should > also have an identifier name" > Found using checkpatch > > Signed-off-by: Derek Robson > > V1 had vauge subjet v2 does as well :( Also this V1 line needs to go below the --- line, otherwise it ends up in the changelog text. Please fix up and make a v3. thanks, greg k-h