From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755120AbdFWUsC (ORCPT ); Fri, 23 Jun 2017 16:48:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:45421 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754955AbdFWUsA (ORCPT ); Fri, 23 Jun 2017 16:48:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,380,1493708400"; d="scan'208";a="118637731" Date: Fri, 23 Jun 2017 13:48:00 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Colin King , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Message-ID: <20170623204759.2op7zhjtfgyqd7db@intel.com> References: <20170623084855.9197-1-colin.king@canonical.com> <20170623085824.yqzachlpvu26knkv@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170623085824.yqzachlpvu26knkv@pd.tnic> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote: > On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > > From: Colin Ian King > > -int sbi_send(int port, int off, int op, u32 *data) > > +static int sbi_send(int port, int off, int op, u32 *data) > > Tony, were those supposed to be used somewhere outside of the driver, > i.e., that CONFIG_X86_INTEL_SBI_APL thing? No. This function is internal and can be static. The CONFIG_X86_INTEL_SBI_APL thing is about sbi_apl_commit() while is still waiting for a sideband driver that defines it to be pushed upstream. -Tony