From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbdFXFtB (ORCPT ); Sat, 24 Jun 2017 01:49:01 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:34443 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbdFXFtA (ORCPT ); Sat, 24 Jun 2017 01:49:00 -0400 Date: Sat, 24 Jun 2017 07:48:49 +0200 From: Alexandre Belloni To: Vaibhav Jain Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Subject: Re: [PATCH] rtc: opal: Implement rtc_class_ops.alarm_irq_enable callback Message-ID: <20170624054849.e2dkt55hjaufisf2@piout.net> References: <20170531130901.31415-1-vaibhav@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531130901.31415-1-vaibhav@linux.vnet.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/2017 at 18:39:01 +0530, Vaibhav Jain wrote: > Provide an implementation of the callback > rtc_class_ops.alarm_irq_enable for rtc-opal driver. This callback is > called when the wake alarm is disabled via the command: > > 'echo 0 > /sys/class/rtc/rtc0/wakealarm' > > Without this the Timed-Power-On(TPO) config remains set even when its > disabled by the above command and FSP will still force machine > boot at previously configured alarm time. > > The callback is implemented as function opal_tpo_alarm_irq_enable() > which calls opal_set_tpo_time() with alarm.enabled == 0. A branch is > added to opal_set_tpo_time() to handle this case by passing y_m_d == > h_m_s_ms == 0 to opal as arguments for opal_tpo_write() call. > > Signed-off-by: Vaibhav Jain > --- > drivers/rtc/rtc-opal.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com