From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbdFYMWV (ORCPT ); Sun, 25 Jun 2017 08:22:21 -0400 Received: from mail-yb0-f196.google.com ([209.85.213.196]:36005 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdFYMWT (ORCPT ); Sun, 25 Jun 2017 08:22:19 -0400 From: Tommy Nguyen To: Greg Kroah-Hartman Cc: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , linux-kernel@vger.kernel.org, Tommy Nguyen Subject: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE Date: Sun, 25 Jun 2017 08:22:06 -0400 Message-Id: <20170625122206.4229-1-remyabel@gmail.com> X-Mailer: git-send-email 2.9.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE and debugfs_create_file_unsafe should be used instead. Signed-off-by: Tommy Nguyen --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 03d3a4f..8f96b38 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, - debug_shrink_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, + debug_shrink_set, "%llu\n"); void ion_device_add_heap(struct ion_heap *heap) { @@ -579,7 +579,7 @@ void ion_device_add_heap(struct ion_heap *heap) char debug_name[64]; snprintf(debug_name, 64, "%s_shrink", heap->name); - debug_file = debugfs_create_file( + debug_file = debugfs_create_file_unsafe( debug_name, 0644, dev->debug_root, heap, &debug_shrink_fops); if (!debug_file) { -- 2.9.4