From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdF0ARq (ORCPT ); Mon, 26 Jun 2017 20:17:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55467 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbdF0ARi (ORCPT ); Mon, 26 Jun 2017 20:17:38 -0400 Date: Mon, 26 Jun 2017 17:17:27 -0700 From: Ram Pai To: Benjamin Herrenschmidt Cc: Balbir Singh , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, paulus@samba.org, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, dave.hansen@intel.com, hbabu@us.ibm.com, arnd@arndb.de, akpm@linux-foundation.org, corbet@lwn.net, mingo@redhat.com Subject: Re: [RFC v3 02/23] powerpc: introduce set_hidx_slot helper Reply-To: Ram Pai References: <1498095579-6790-1-git-send-email-linuxram@us.ibm.com> <1498095579-6790-3-git-send-email-linuxram@us.ibm.com> <1498431798.7935.5.camel@gmail.com> <1498449778.31581.118.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498449778.31581.118.camel@kernel.crashing.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17062700-0024-0000-0000-0000029F0454 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007283; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00879175; UDB=6.00438153; IPR=6.00659329; BA=6.00005443; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015961; XFM=3.00000015; UTC=2017-06-27 00:17:36 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062700-0025-0000-0000-00004488F145 Message-Id: <20170627001727.GB5846@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-26_17:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706270002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 25, 2017 at 11:02:58PM -0500, Benjamin Herrenschmidt wrote: > On Mon, 2017-06-26 at 09:03 +1000, Balbir Singh wrote: > > On Wed, 2017-06-21 at 18:39 -0700, Ram Pai wrote: > > > Introduce set_hidx_slot() which sets the (H_PAGE_F_SECOND|H_PAGE_F_GIX) > > > bits at the appropriate location in the PTE of 4K PTE. In the > > > case of 64K PTE, it sets the bits in the second part of the PTE. Though > > > the implementation for the former just needs the slot parameter, it does > > > take some additional parameters to keep the prototype consistent. > > > > > > This function will come in handy as we work towards re-arranging the > > > bits in the later patches. > > The name somewhat sucks. Something like pte_set_hash_slot() or > something like that would be much more meaningful. ok. pte_set_hash_slot() sounds good. RP