From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbdF0HxS (ORCPT ); Tue, 27 Jun 2017 03:53:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbdF0HxN (ORCPT ); Tue, 27 Jun 2017 03:53:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0042FC04B92C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0042FC04B92C Date: Tue, 27 Jun 2017 09:53:05 +0200 From: Benjamin Tissoires To: Christopher Bachner Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus Message-ID: <20170627075305.GZ26073@mail.corp.redhat.com> References: <20170626082626.797-1-benjamin.tissoires@redhat.com> <20170626153856.GV26073@mail.corp.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170626153856.GV26073@mail.corp.redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 27 Jun 2017 07:53:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 26 2017 or thereabouts, Christopher Bachner wrote: > > Hello, > > > > I am assuming that if the inertouch message is not showing up in dmesg, > > then it is working. Is that a correct assumption? > > > > Either way I also attached my dmesg. > > > > I am not sure, though, why the scroll mode still freezes if I move the my > > fingers quickly on the touchpad while also using the trackpoint. Is that > > maybe a future fix and this change is just the foundation for it? Overall > > the usage of the trackpoint is better now for sure. > > Sadly, you are also hit by: > [ 6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers > [ 6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited > > Which disables entirely the RMI4 over SMBus module. And then we can not > probe for it, meaning you are stuck with the PS/2 crappy mode. > > We are aware of this bug and we'll try to fix that. I think the test you > provides are valid (the patch works as expected), but a different bug > prevents rmi-smbus to fully initialize the touchpad :( Could you try applying Lyude's patch: http://patchwork.ozlabs.org/patch/780865/ (on top of mine, of course). In the dmesg, you should see a Synaptics TMXXXX device appearing after trying to set up the SMBus companion. Cheers, Benjamin