From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbdF0Nie (ORCPT ); Tue, 27 Jun 2017 09:38:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:60888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbdF0Nia (ORCPT ); Tue, 27 Jun 2017 09:38:30 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D89B322B61 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 27 Jun 2017 09:38:25 -0400 From: Steven Rostedt To: "Kirill A. Shutemov" Cc: Ingo Molnar , x86@kernel.org, Fengguang Wu , lkp@01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/ftrace: Exclude functions in head64.c from function-tracing Message-ID: <20170627093825.0d0276ba@gandalf.local.home> In-Reply-To: <20170627115948.17938-1-kirill.shutemov@linux.intel.com> References: <20170627033414.chxwdvlvc2smnm3s@wfg-t540p.sh.intel.com> <20170627115948.17938-1-kirill.shutemov@linux.intel.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jun 2017 14:59:48 +0300 "Kirill A. Shutemov" wrote: > We've moved most logic of early boot up from startup_64() written in > assembly to __startup_64() written in C. > > Fengguang reported breakage due to the change. It was tracked down to > CONFIG_FUNCTION_TRACER being enabled. Is this due to code that is in linux-next or is this issue currently in mainline? If it is in linux-next, I'll give you: Acked-by: Steven Rostedt (VMware) and you can take it. If the issue happens in current mainline, then I'll take it and push it out. -- Steve > > Looks like function-tracing of the new code is harmful. > > Let's not comple the code with -pg compiler option. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Fengguang Wu > Cc: Steven Rostedt > --- > arch/x86/kernel/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index 4b994232cb57..0db512092f37 100644 > --- a/arch/x86/kernel/Makefile > +++ b/arch/x86/kernel/Makefile > @@ -18,6 +18,7 @@ CFLAGS_REMOVE_pvclock.o = -pg > CFLAGS_REMOVE_kvmclock.o = -pg > CFLAGS_REMOVE_ftrace.o = -pg > CFLAGS_REMOVE_early_printk.o = -pg > +CFLAGS_REMOVE_head64.o = -pg > endif > > KASAN_SANITIZE_head$(BITS).o := n