From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbdF0SPn (ORCPT ); Tue, 27 Jun 2017 14:15:43 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:56815 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbdF0SPg (ORCPT ); Tue, 27 Jun 2017 14:15:36 -0400 Date: Tue, 27 Jun 2017 20:15:35 +0200 From: Alexandre Belloni To: Maxime Ripard Cc: icenowy@aosc.io, techping.chan@gmail.com, Chen-Yu Tsai , Rob Herring , mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Message-ID: <20170627181535.2nhd3rd542wpryjy@piout.net> References: <20170624024515.4669-1-techping.chan@gmail.com> <20170624024515.4669-3-techping.chan@gmail.com> <20170626171524.cqfyasetpsfr6xfg@flea.lan> <24845446a80e3542d90a1111a6141415@aosc.io> <20170627173631.2rjdzgwdwnksqjzm@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627173631.2rjdzgwdwnksqjzm@flea> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/2017 at 19:36:31 +0200, Maxime Ripard wrote: > Hi, > > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy@aosc.io wrote: > > Maxime, here's another problem: if we have already a GP LRADC driver, > > how can we tell the kernel to use it as IIO ADC rather than keys? > > The GPADC IIO driver is not for the LRADC driver, but the GPADC / > temperature sensor. > > We used to have an LRADC IIO driver in the CHIP BSP written by Alex > (in CC): > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27 > > But he never mainlined it. > > > Should we introduce a new property for this once ready? > > We need to keep the current binding. We can just check for the > presence or not of child nodes to see if it has some keys, and we'd > need an IIO-to-input driver that is yet to be written. > The whole submission is here and can already replace the existing driver but it will be polling instead of using interrupts: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-July/440734.html It is not upstream because it seems the full replacement was required at once instead of doing it incrementally and there was (is) no API for in-kernel events consumers. Also, the DT ABI stuff would have to be solved. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com