From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbdF1LpS (ORCPT ); Wed, 28 Jun 2017 07:45:18 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38639 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbdF1LpM (ORCPT ); Wed, 28 Jun 2017 07:45:12 -0400 Date: Wed, 28 Jun 2017 14:45:00 +0300 From: Dan Carpenter To: Len Brown Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] tools/power x86_energy_perf_policy: remove unneeded check Message-ID: <20170628114500.bw2yhctvm6feo3hp@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "i" is an int so this test is only ever possible with 32 bit systems. The error message is not very useful and there are better tests directly afterward so this test isn't needed. Let's just delete these lines. Signed-off-by: Dan Carpenter diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 65bbe627a425..de4a888f1a3e 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -332,8 +332,6 @@ int parse_optarg_string(char *s) fprintf(stderr, "no digits in \"%s\"\n", s); usage(); } - if (i == LONG_MIN || i == LONG_MAX) - errx(-1, "%s", s); if (i > 0xFF) errx(-1, "%d (0x%x) must be < 256", i, i);