From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaya Durga <rjdurga@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
florian.c.schilhabel@googlemail.com, Jaya Durga <jayad@cdac.in>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding
Date: Wed, 28 Jun 2017 15:45:22 +0300 [thread overview]
Message-ID: <20170628124522.v4p2ksnexzad2krh@mwanda> (raw)
In-Reply-To: <1498563819-31358-1-git-send-email-rjdurga@gmail.com>
On Tue, Jun 27, 2017 at 05:13:39PM +0530, Jaya Durga wrote:
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 1985423..dac6aed 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -29,7 +29,10 @@
> #include "osdep_service.h"
> #include "drv_types.h"
>
> -#define RND4(x) ((((x) >> 2) + ((((x) & 3) == 0) ? 0 : 1)) << 2)
> +static inline unsigned int RND4(unsigned int x)
> +{
> + return (((x >> 2) + (((x & 3) == 0) ? 0 : 1)) << 2);
> +}
>
Don't mix unrelated stuff.
regards,
dan carpenter
prev parent reply other threads:[~2017-06-28 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 11:43 Jaya Durga
2017-06-28 12:45 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628124522.v4p2ksnexzad2krh@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jayad@cdac.in \
--cc=linux-kernel@vger.kernel.org \
--cc=rjdurga@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®