From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbdF1Ppo (ORCPT ); Wed, 28 Jun 2017 11:45:44 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36844 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdF1Ppi (ORCPT ); Wed, 28 Jun 2017 11:45:38 -0400 Date: Wed, 28 Jun 2017 11:44:24 -0400 From: Konrad Rzeszutek Wilk To: Vitaly Kuznetsov Cc: xen-devel@lists.xenproject.org, Juergen Gross , Boris Ostrovsky , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining Message-ID: <20170628154424.GH30116@char.us.oracle.com> References: <20170626163930.29697-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170626163930.29697-1-vkuznets@redhat.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2017 at 06:39:30PM +0200, Vitaly Kuznetsov wrote: > CONFIG_BOOTPARAM_HOTPLUG_CPU0 allows to offline CPU0 but Xen HVM guests > BUG() in xen_teardown_timer(). Remove the BUG_ON(), this is probably a > leftover from ancient times when CPU0 hotplug was impossible, it works > just fine for HVM. > > Signed-off-by: Vitaly Kuznetsov Perhaps: BUG_ON(cpu == 0 && xen_pv_domain()); ? > --- > - CPU0 hotplug is currently broken on x86, see > https://lkml.org/lkml/2017/6/26/529 > --- > arch/x86/xen/time.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index a1895a8..1ecb05d 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -309,7 +309,6 @@ static irqreturn_t xen_timer_interrupt(int irq, void *dev_id) > void xen_teardown_timer(int cpu) > { > struct clock_event_device *evt; > - BUG_ON(cpu == 0); > evt = &per_cpu(xen_clock_events, cpu).evt; > > if (evt->irq >= 0) { > -- > 2.9.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel