From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdF1Fqp (ORCPT ); Wed, 28 Jun 2017 01:46:45 -0400 Received: from ozlabs.org ([103.22.144.67]:43865 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbdF1Fqh (ORCPT ); Wed, 28 Jun 2017 01:46:37 -0400 Date: Wed, 28 Jun 2017 15:46:34 +1000 From: Stephen Rothwell To: "Nicholas A. Bellinger" , James Bottomley Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Quinn Tran , "Martin K. Petersen" , Himanshu Madhani Subject: Re: linux-next: manual merge of the target-updates tree with the scsi tree Message-ID: <20170628154634.6807e0b3@canb.auug.org.au> In-Reply-To: <20170628154059.21dbfda2@canb.auug.org.au> References: <20170628154059.21dbfda2@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Wed, 28 Jun 2017 15:40:59 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the target-updates tree got a conflict in: > > drivers/scsi/qla2xxx/qla_target.c > > between commits: > > f775bd14e44d ("scsi: qla2xxx: Convert 32-bit LUN usage to 64-bit") > 82de802ad46e ("scsi: qla2xxx: Preparation for Target MQ.") > > from the scsi tree and commit: > > 6b26726af699 ("qla2xxx: Convert QLA_TGT_ABTS to TARGET_SCF_LOOKUP_LUN_FROM_TAG") > > from the target-updates tree. > > I fixed it up (I think - see below) and can carry the fix as OK, that was no right :-( I have added the following fix patch as well (I suggest someone provide me with the correct fixup for tomorrow, please). From: Stephen Rothwell Date: Wed, 28 Jun 2017 15:44:27 +1000 Subject: [PATCH] qla2xxx: fix up for bad merge fix Signed-off-by: Stephen Rothwell --- drivers/scsi/qla2xxx/qla_target.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 9a054439560d..42a3f5be818c 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -1875,7 +1875,6 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha, { struct qla_hw_data *ha = vha->hw; struct qla_tgt_mgmt_cmd *mcmd; - struct qla_tgt_cmd *cmd; int rc; if (abort_cmd_for_tag(vha, abts->exchange_addr_to_abort)) { @@ -1898,14 +1897,13 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha, } memset(mcmd, 0, sizeof(*mcmd)); - cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd); mcmd->sess = sess; memcpy(&mcmd->orig_iocb.abts, abts, sizeof(mcmd->orig_iocb.abts)); mcmd->reset_count = ha->base_qpair->chip_reset; mcmd->tmr_func = QLA_TGT_ABTS; mcmd->qpair = ha->base_qpair; - rc = ha->tgt.tgt_ops->handle_tmr(mcmd, cmd->unpacked_lun, mcmd->tmr_func, + rc = ha->tgt.tgt_ops->handle_tmr(mcmd, 0, mcmd->tmr_func, abts->exchange_addr_to_abort); if (rc != 0) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf052, -- 2.11.0 -- Cheers, Stephen Rothwell