mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fathi Boudra <fathi.boudra@linaro.org>
To: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	John Stultz <john.stultz@linaro.org>,
	Denys Dmytriyenko <denys@ti.com>,
	SeongJae Park <sj38.park@gmail.com>,
	Fathi Boudra <fathi.boudra@linaro.org>
Subject: [PATCH 0/3] selftests: fixes for undefined reference (LDFLAGS -> LDLIBS)
Date: Wed, 28 Jun 2017 20:08:56 +0300	[thread overview]
Message-ID: <20170628170859.28583-1-fathi.boudra@linaro.org> (raw)

This serie fixes undefined reference errors caused by the usage of LDFLAGS
instead of LDLIBS.

The issue is GNU Make and linker specific.

The default Makefile rule looks like:

$(CC) $(CFLAGS) $(LDFLAGS) $@ $^ $(LDLIBS)

When linking is done by gcc itself, no issue, but when it needs to be passed
to proper ld, only LDLIBS follows and then ld cannot know what libs to link
with.

More detail:
https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

LDFLAGS
Extra flags to give to compilers when they are supposed to invoke the linker,
‘ld’, such as -L. Libraries (-lfoo) should be added to the LDLIBS variable
instead.

LDLIBS
Library flags or names given to compilers when they are supposed to invoke the
linker, ‘ld’. LOADLIBES is a deprecated (but still supported) alternative to
LDLIBS. Non-library linker flags, such as -L, should go in the LDFLAGS
variable.

https://lkml.org/lkml/2010/2/10/362

tools/perf: libraries must come after objects

Link order matters.

Fathi Boudra (3):
  selftests: net: use LDLIBS instead of LDFLAGS
  selftests: seccomp: use LDLIBS instead of LDFLAGS
  selftests: timers: use LDLIBS instead of LDFLAGS

 tools/testing/selftests/net/Makefile     | 2 +-
 tools/testing/selftests/seccomp/Makefile | 4 ++--
 tools/testing/selftests/timers/Makefile  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.13.0

             reply	other threads:[~2017-06-28 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 17:08 Fathi Boudra [this message]
2017-06-28 17:08 ` [PATCH 1/3] selftests: net: use LDLIBS instead of LDFLAGS Fathi Boudra
2017-06-28 17:08 ` [PATCH 2/3] selftests: seccomp: " Fathi Boudra
2017-06-28 21:40   ` sjpark
2017-06-29  7:02     ` Fathi Boudra
2017-06-28 17:08 ` [PATCH 3/3] selftests: timers: " Fathi Boudra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628170859.28583-1-fathi.boudra@linaro.org \
    --to=fathi.boudra@linaro.org \
    --cc=denys@ti.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=sj38.park@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®