From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbdF1VZ0 (ORCPT ); Wed, 28 Jun 2017 17:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbdF1VZR (ORCPT ); Wed, 28 Jun 2017 17:25:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4179C80F95 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rgb@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4179C80F95 Date: Wed, 28 Jun 2017 17:25:06 -0400 From: Richard Guy Briggs To: Paul Moore Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com, Greg Kroah-Hartman , Steven Rostedt , Ingo Molnar , Al Viro Subject: Re: [PATCH ALT4 V2 2/2] audit: filter PATH records keyed on filesystem magic Message-ID: <20170628212506.GF27193@madcap2.tricolour.ca> References: <20170627204537.GD27193@madcap2.tricolour.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 28 Jun 2017 21:25:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-06-28 15:08, Paul Moore wrote: > On Tue, Jun 27, 2017 at 4:45 PM, Richard Guy Briggs wrote: > > On 2017-05-30 17:30, Paul Moore wrote: > >> On Tue, Apr 4, 2017 at 5:21 AM, Richard Guy Briggs wrote: > >> > Tracefs or debugfs were causing hundreds to thousands of PATH records to > >> > be associated with the init_module and finit_module SYSCALL records on a > >> > few modules when the following rule was in place for startup: > >> > -a always,exit -F arch=x86_64 -S init_module -F key=mod-load > >> > > >> > Provide a method to ignore these large number of PATH records from > >> > overwhelming the logs if they are not of interest. Introduce a new > >> > filter list "AUDIT_FILTER_PATH", with a new field type AUDIT_FSTYPE, > >> > which keys off the filesystem 4-octet hexadecimal magic identifier to > >> > filter specific filesystem PATH records. > >> > > >> > An example rule would look like: > >> > -a never,path -F fstype=0x74726163 -F key=ignore_tracefs > >> > -a never,path -F fstype=0x64626720 -F key=ignore_debugfs > >> > >> Trying to look into the future I wonder if we are ever going to need > >> to expand the "path" filtering to regular inode lookups, e.g. > >> audit_inode()? > > > > That thought had occurred to me. Do you see any concern with that that > > would affect this patch in terms of naming? > > Well, you want to change this to "fs" now instead of "path", right? I > think that removes my concerns. That's fixed in my cleanup that I'm waiting to push. In fact it is "filesystem" in the userspace patch. > > I could see expanding this filter to include other filter fields though > > nothing specific comes to mind now. > > paul moore - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635