From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdF2IyN (ORCPT ); Thu, 29 Jun 2017 04:54:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:44499 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752117AbdF2IyC (ORCPT ); Thu, 29 Jun 2017 04:54:02 -0400 Date: Thu, 29 Jun 2017 10:53:57 +0200 From: Michal Hocko To: Roman Gushchin Cc: linux-mm@kvack.org, Vladimir Davydov , Johannes Weiner , Tejun Heo , Tetsuo Handa , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3 5/6] mm, oom: don't mark all oom victims tasks with TIF_MEMDIE Message-ID: <20170629085357.GF31603@dhcp22.suse.cz> References: <1498079956-24467-1-git-send-email-guro@fb.com> <1498079956-24467-6-git-send-email-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498079956-24467-6-git-send-email-guro@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 21-06-17 22:19:15, Roman Gushchin wrote: > We want to limit the number of tasks which are having an access > to the memory reserves. To ensure the progress it's enough > to have one such process at the time. > > If we need to kill the whole cgroup, let's give an access to the > memory reserves only to the first process in the list, which is > (usually) the biggest process. > This will give us good chances that all other processes will be able > to quit without an access to the memory reserves. I don't like this to be honest. Is there any reason to go the reduced memory reserves access to oom victims I was suggesting earlier [1]? [1] http://lkml.kernel.org/r/http://lkml.kernel.org/r/1472723464-22866-2-git-send-email-mhocko@kernel.org -- Michal Hocko SUSE Labs