From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdF2MMH (ORCPT ); Thu, 29 Jun 2017 08:12:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:35359 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752347AbdF2MMB (ORCPT ); Thu, 29 Jun 2017 08:12:01 -0400 Date: Thu, 29 Jun 2017 14:11:54 +0200 From: Michal Hocko To: Dou Liyang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, David Rientjes , isimatu.yasuaki@jp.fujitsu.com Subject: Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node() Message-ID: <20170629121154.GA5039@dhcp22.suse.cz> References: <1498013846-20149-1-git-send-email-douly.fnst@cn.fujitsu.com> <20170629111217.GA5032@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 29-06-17 19:58:52, Dou Liyang wrote: > Hi Michal, > > At 06/29/2017 07:12 PM, Michal Hocko wrote: > >On Wed 21-06-17 10:57:26, Dou Liyang wrote: > >>... initializes local parameters "p_node" & "parent" for > >>register_node(). > >> > >>But, register_node() does not use them. > >> > >>Remove the related code of "parent" node, cleanup __register_one_node() > >>and register_node(). > >> > >>Cc: Andrew Morton > >>Cc: David Rientjes > >>Cc: Michal Hocko > >>Cc: isimatu.yasuaki@jp.fujitsu.com > >>Signed-off-by: Dou Liyang > >>Acked-by: David Rientjes > > > >I am sorry, this slipped through cracks. > >Acked-by: Michal Hocko > > Thanks for your Acked-by, but this patch has been added to the -mm tree. > Its filename is > mm-drop-useless-local-parameters-of-__register_one_node.patch Yeah, don't worry. Andrew will add the acked-by in his tree. > This patch should soon appear at > > http://ozlabs.org/~akpm/mmots/broken-out/mm-drop-useless-local-parameters-of-__register_one_node.patch > and later at > > http://ozlabs.org/~akpm/mmotm/broken-out/mm-drop-useless-local-parameters-of-__register_one_node.patch > > I don't know what should I do next ? :) Wait for Andrew to send this to Linus during the next merge window. -- Michal Hocko SUSE Labs