From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbdF2SWi (ORCPT ); Thu, 29 Jun 2017 14:22:38 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:39580 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdF2SWb (ORCPT ); Thu, 29 Jun 2017 14:22:31 -0400 Date: Thu, 29 Jun 2017 20:22:16 +0200 From: Andrew Lunn To: David Miller Cc: linyunsheng@huawei.com, f.fainelli@gmail.com, huangdaode@hisilicon.com, xuwei5@hisilicon.com, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, gabriele.paoloni@huawei.com, john.garry@huawei.com, linuxarm@huawei.com, salil.mehta@huawei.com, lipeng321@huawei.com, tremyfr@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix Message-ID: <20170629182216.GB17212@lunn.ch> References: <1498641191-13343-1-git-send-email-linyunsheng@huawei.com> <20170629.141455.1338948120889824664.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629.141455.1338948120889824664.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 02:14:55PM -0400, David Miller wrote: > From: Lin Yun Sheng > Date: Wed, 28 Jun 2017 17:13:09 +0800 > > > This Patch Set add set_loopback in phy_driver and use it to setup loopback > > when doing ethtool phy self_test. > > This doesn't apply cleanly to the net-next tree, please respin. Hi David This patchset still has issues. The first patch is O.K. to be committed, but the second patch to the hns driver still has issues. I suppose it makes the hns driver less broken, but it is still broken. Is less broken a sufficient criteria for acceptance? Andrew