From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbdF2VqW (ORCPT ); Thu, 29 Jun 2017 17:46:22 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:59322 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753151AbdF2VpT (ORCPT ); Thu, 29 Jun 2017 17:45:19 -0400 Message-Id: <20170629213334.375848050@linutronix.de> User-Agent: quilt/0.63-1 Date: Thu, 29 Jun 2017 23:33:34 +0200 From: Thomas Gleixner To: LKML Cc: Marc Zyngier , Linus Walleij , Brian Norris , Heiko Stuebner , linux-rockchip@lists.infradead.org, Julia Cartwright , linux-gpio@vger.kernel.org, John Keeping , Doug Anderson Subject: [patch 0/5] genirq: Distangle irq_request/release_resources() from irq_desc->lock Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The irq_request/release_resources() callbacks are a problem on RT as they are called under irq_desc->lock with interrupts disabled. Aside of that calling them under irq_desc->lock is conceptually wrong and has a (hard to trigger and probably theoretical) issue in free_irq(). See patch 4/5 for a detailed explanation. The series contains also a fix for the exynos gpio driver, which fiddles with the irq masking in the resource callbacks, which is bogus and potentially harmful. Finally it moves the irq timings deallocation out of the spin locked region. Thanks, tglx --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 -- include/linux/irqdesc.h | 3 + kernel/irq/irqdesc.c | 1 kernel/irq/manage.c | 47 +++++++++++++++++++------------ 4 files changed, 34 insertions(+), 21 deletions(-)