From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbdF3QpN (ORCPT ); Fri, 30 Jun 2017 12:45:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44198 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbdF3QpL (ORCPT ); Fri, 30 Jun 2017 12:45:11 -0400 Date: Fri, 30 Jun 2017 12:45:05 -0400 (EDT) Message-Id: <20170630.124505.736865959393416284.davem@davemloft.net> To: ebiederm@xmission.com Cc: linux-kernel@vger.kernel.org, luto@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, oleg@redhat.com, avagin@virtuozzo.com, tglx@linutronix.de, greg@kroah.com, avagin@openvz.org, serge@hallyn.com, xemul@virtuozzo.com, gorcunov@openvz.org, peterz@infradead.org, w@1wt.eu, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, mtk.manpages@gmail.com, sparclinux@vger.kernel.org Subject: Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE From: David Miller In-Reply-To: <20170630123906.8865-3-ebiederm@xmission.com> References: <87efu22set.fsf@xmission.com> <20170630123906.8865-3-ebiederm@xmission.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 30 Jun 2017 09:45:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Eric W. Biederman" Date: Fri, 30 Jun 2017 07:39:01 -0500 > diff --git a/arch/sparc/include/uapi/asm/siginfo.h b/arch/sparc/include/uapi/asm/siginfo.h > index 2d9b79ccaa50..6bc5c677e92f 100644 > --- a/arch/sparc/include/uapi/asm/siginfo.h > +++ b/arch/sparc/include/uapi/asm/siginfo.h > @@ -17,6 +17,11 @@ > #define SI_NOINFO 32767 /* no information in siginfo_t */ > > /* > + * SIGFPE si_codes > + */ > +#define FPE_FIXME (__SI_FAULT|0) /* Broken dup of SI_USER */ > + > +/* > * SIGEMT si_codes > */ > #define EMT_TAGOVF (__SI_FAULT|1) /* tag overflow */ It's one thing to say FIXME in a comment in a kernel local header or C file. It's quite another to put this into the name of a macro which has visibility in the global user compilation namespace. I don't think you should really do that.