From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753206AbdF2Q70 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 12:59:26 -0400
Received: from mail-pg0-f54.google.com ([74.125.83.54]:34115 "EHLO
        mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752841AbdF2Q6m (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 12:58:42 -0400
Date: Fri, 30 Jun 2017 02:58:26 +1000
From: Nicholas Piggin <npiggin@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Build failure in -next due to 'sh: thin archives fix linking'
Message-ID: <20170630025826.494397c4@roar.ozlabs.ibm.com>
In-Reply-To: <CAK7LNAQ5rY+5Fv_bvr2cqg2Se1k_abAH1qkAUECdjEhE=4H=5g@mail.gmail.com>
References: <77ef6224-28f6-d71d-29d8-74b41fa26f0b@roeck-us.net>
        <20170628225837.25abba1e@roar.ozlabs.ibm.com>
        <4a610d3a-76de-7fec-40dc-61ec5ef175ee@roeck-us.net>
        <CAK7LNAQ5rY+5Fv_bvr2cqg2Se1k_abAH1qkAUECdjEhE=4H=5g@mail.gmail.com>
Organization: IBM
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Jun 2017 00:36:42 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> Hi.
> 
> 2017-06-28 23:02 GMT+09:00 Guenter Roeck <linux@roeck-us.net>:
> > On 06/28/2017 05:58 AM, Nicholas Piggin wrote:  
> >>
> >> On Wed, 28 Jun 2017 05:38:50 -0700
> >> Guenter Roeck <linux@roeck-us.net> wrote:
> >>  
> >>> Hi,
> >>>
> >>> I see the following build error in -next when building
> >>> sh:rts7751r2dplus_defconfig.
> >>>
> >>> sh4-linux-ld: arch/sh/kernel/vsyscall/vsyscall-dummy.o: compiled for a
> >>> big endian system and target is little endian
> >>> sh4-linux-ld: arch/sh/kernel/vsyscall/vsyscall-dummy.o: uses instructions
> >>> which are incompatible with instructions used in previous modules
> >>> sh4-linux-ld: failed to merge target specific data of file
> >>> arch/sh/kernel/vsyscall/vsyscall-dummy.o
> >>> make[2]: *** [arch/sh/kernel/vsyscall/vsyscall-syms.o] Error 1
> >>>
> >>> Bisect points to 'sh: thin archives fix linking' as the culprit. Bisect
> >>> log is attached.
> >>> I tried with gcc 4.8.3 and 6.3.0, both built with buildroot for sh4eb.  
> >>
> >>
> >> Thanks for the report. In arch/sh/kernel/vsyscall/Makefile, the line:
> >>
> >>   cmd_syscall_syms = $(LD) -r -o $@ -R $<
> >>
> >> Can you try adding $(LDFLAGS), e.g. change it to:
> >>
> >>   cmd_syscall_syms = $(LD) $(LDFLAGS) -r -o $@ -R $<
> >>  
> >
> > That fixes the problem (including the missing symbols seen after reverting
> > the offending patch).  
> 
> 
> Thanks!
> 
> Instead of adding $(LDFLAGS), how about using cmd_ld?
> 
> 
> Please see line 260 of scripts/Makefile.lib
> 
> quiet_cmd_ld = LD      $@
> cmd_ld = $(LD) $(LDFLAGS) $(ldflags-y) $(LDFLAGS_$(@F)) \
>                $(filter-out FORCE,$^) -o $@
> 
> We can reuse it and $(LDFLAGS) is already there.
> 
> 
> 
> I also noticed redundant "targets += gate-syms.o"
> I see "obj-y += gate-syms.o" and $(obj-y) is automatically
> added to "targets".
> 
> 
> The following diff is my proposal.
> If it is OK, I will squash it and update the thin-ar branch.

Yes, I think this is much better. Thank you! Please squash it in.

Thanks,
Nick