From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdF3JD6 (ORCPT ); Fri, 30 Jun 2017 05:03:58 -0400 Received: from sauhun.de ([88.99.104.3]:34372 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbdF3JD5 (ORCPT ); Fri, 30 Jun 2017 05:03:57 -0400 Date: Fri, 30 Jun 2017 11:03:55 +0200 From: Wolfram Sang To: Andy Shevchenko Cc: Chris Packham , linux-i2c , Yoshinori Sato , Linux-SH , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Message-ID: <20170630090354.6s6ahpjhis7ptbfg@ninjato> References: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> <20170630005408.23968-6-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qq5nbduvabei5q57" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qq5nbduvabei5q57 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > - i2c->algo_data.i2c_clock =3D 59000; > > + ret =3D device_property_read_u32(&pdev->dev, "clock-fre= quency", > > + &i2c->algo_data.i2c_cloc= k); > > + if (ret) > > + i2c->algo_data.i2c_clock =3D 59000; >=20 > My idea is to get rid of legacy platform data completely. > That's why I suggested device_* in the first place. >=20 > In similar way like you did with GPIO lookup table, you may use > PROPERTY_ENTRY*() macros in the board files. >=20 > Does it make sense? Frankly, I am not a big fan of converting board files if we cannot test the changes. --qq5nbduvabei5q57 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAllWE/oACgkQFA3kzBSg KbZ+mg/9HiJeVWAZlhH8PrUuRhuL6x6YwBPV196+ziXxc8MmaCGeO8b+7yYSPfWZ zSecMUBFLmXaFljK8T4BpB89V2bR8Vo3TvSJWP46eIN0rHtxDQwGWHX3yfwJcitN 6FojbfZfxve0hui0CkH2EE2XlgbSDS6Dd3FjZCOtlOdG1RWvz+cYqxXLnVN9k75s xfbx0yWpUhlmvxtqDzla/lZPoqYvR7iZJ152djs8eyaVWgkslJX0YHMcR46+5l2i rnYpMQP9RxZMX7IXJjaY/oC+MqlXnxG7F8pDAN7CYRVGz3r6Ev5qB7iXTF+rUG63 mMI7ufju9IEKoO112/o3bZNw3jPt+MO9p0pc23egYPLZSAZ6ICZidkywUMBzMFlw ayCOM6/Wlpubw/XF9eQxiYJjhb5hytjTPS2jHN8n9aabJ9rLRzaAqJZjQqSvY3+L m76ZccYhUTHWcwtn+Trdc8AP9juv07VKCnmq/S8d8v0vUj9zfP5JhLic6x5mAezN uYGu1w4gG3mIKEoCV9hezzb6adreBuD2tooexhKKFGoJoX24Hpz336O8aBIBWtwb FsuK/J9GWL275tE8xHeUv1SwhqEBSilF6kgiV0VdYdGhRZz3M8Oj7UTJZcCeBldE sSdrXgPYdE0V57y37JBA5tgi24lQKN17Ksbhjth0807N+3HoLco= =8IhU -----END PGP SIGNATURE----- --qq5nbduvabei5q57--