From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdF3KeD (ORCPT ); Fri, 30 Jun 2017 06:34:03 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59432 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420AbdF3Kd5 (ORCPT ); Fri, 30 Jun 2017 06:33:57 -0400 From: Colin King To: Linus Walleij , linux-gpio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: rza1: fix incorrect failure check on platform_get_resources Date: Fri, 30 Jun 2017 11:33:55 +0100 Message-Id: <20170630103355.9769-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The return res from platform_get_resources should be checked for a failure rather than ret. Fixes warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") Signed-off-by: Colin Ian King --- drivers/pinctrl/pinctrl-rza1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c index 29ddd624fb98..e79c8b9818d7 100644 --- a/drivers/pinctrl/pinctrl-rza1.c +++ b/drivers/pinctrl/pinctrl-rza1.c @@ -1257,7 +1257,7 @@ static int rza1_pinctrl_probe(struct platform_device *pdev) rza1_pctl->dev = &pdev->dev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (ret) + if (!res) return -ENODEV; rza1_pctl->base = devm_ioremap_resource(&pdev->dev, res); -- 2.11.0