From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbdF3Mrp (ORCPT ); Fri, 30 Jun 2017 08:47:45 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:35272 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdF3Mrl (ORCPT ); Fri, 30 Jun 2017 08:47:41 -0400 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Linus Torvalds , Al Viro , Oleg Nesterov , Andrei Vagin , Thomas Gleixner , Greg KH , Andrey Vagin , Serge Hallyn , Pavel Emelyanov , Cyrill Gorcunov , Peter Zijlstra , Willy Tarreau , linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Linux Containers , Michael Kerrisk , "Eric W. Biederman" , Will Drewry , "H . Peter Anvin" , Eric Paris , James Morris Date: Fri, 30 Jun 2017 07:39:04 -0500 Message-Id: <20170630123906.8865-6-ebiederm@xmission.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <87efu22set.fsf@xmission.com> References: <87efu22set.fsf@xmission.com> X-XM-SPF: eid=1dQvKg-00026H-9Z;;;mid=<20170630123906.8865-6-ebiederm@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=67.3.213.87;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+H6765eAIoHEiunbD5pmMNFrkXb/8WRsA= X-SA-Exim-Connect-IP: 67.3.213.87 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.5 XMGappySubj_01 Very gappy subject * 0.7 XMSubLong Long Subject * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 5806 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 2.8 (0.0%), b_tie_ro: 1.88 (0.0%), parse: 1.30 (0.0%), extract_message_metadata: 45 (0.8%), get_uri_detail_list: 2.3 (0.0%), tests_pri_-1000: 28 (0.5%), tests_pri_-950: 2.1 (0.0%), tests_pri_-900: 1.72 (0.0%), tests_pri_-400: 34 (0.6%), check_bayes: 32 (0.6%), b_tokenize: 15 (0.3%), b_tok_get_all: 8 (0.1%), b_comp_prob: 3.8 (0.1%), b_tok_touch_all: 3.1 (0.1%), b_finish: 0.77 (0.0%), tests_pri_0: 506 (8.7%), check_dkim_signature: 0.82 (0.0%), check_dkim_adsp: 6 (0.1%), tests_pri_500: 5180 (89.2%), poll_dns_idle: 5171 (89.1%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 6/8] signal/x86: Fix SIGSYS handling in copy_siginfo_to_user32 X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While examining the code I realized that we don't copy si_call_addr to 32bit callers. Fix it. It looks like no one has used this code path in the last 5 years. Cc: Will Drewry Cc: H. Peter Anvin Cc: Eric Paris Cc: Serge Hallyn Cc: James Morris Fixes: a0727e8ce513 ("signal, x86: add SIGSYS info and make it synchronous.") Signed-off-by: "Eric W. Biederman" --- arch/x86/kernel/signal_compat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/signal_compat.c b/arch/x86/kernel/signal_compat.c index 71beb28600d4..59e1029bb3d0 100644 --- a/arch/x86/kernel/signal_compat.c +++ b/arch/x86/kernel/signal_compat.c @@ -161,6 +161,7 @@ int __copy_siginfo_to_user32(compat_siginfo_t __user *to, const siginfo_t *from, } break; case __SI_SYS >> 16: + put_user_ex(ptr_to_compat(from->si_call_addr), &to->si_call_addr); put_user_ex(from->si_syscall, &to->si_syscall); put_user_ex(from->si_arch, &to->si_arch); break; -- 2.10.1