From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbdF3QLA (ORCPT ); Fri, 30 Jun 2017 12:11:00 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:49977 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbdF3QK6 (ORCPT ); Fri, 30 Jun 2017 12:10:58 -0400 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , Jacopo Mondi , Geert Uytterhoeven , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: rza1: fix error handling Date: Fri, 30 Jun 2017 18:09:53 +0200 Message-Id: <20170630161009.13762-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:zGs9otbEqoD0He2rXnOYe15PVR8f6wTkvXXrMU18hdf4BISv0N6 3wT6RwAEhNLflsf7M3NUoHp9b2BIUrT6RRuvgQem7wHhp5chwDYtlvyuRMpSzG9i2onPFqP 2qYi5CGakyaZtDtx9avG7UlyTlSFgGfrb0O925PXpApBGGlp0FnOGVd/X9CW0MX87qBBaOG j38WNB64wRLnvXLXcVd8A== X-UI-Out-Filterresults: notjunk:1;V01:K0:ptg8c/NX8KU=:TQB4OorDd+/pSNM3PxnFzV hLo6SaN/fdbGPzu2s5aqH2YYRjkeLMaO5B/GwNiLf5hObNCScC/HJzr6eR993GeJUMWfSF+YG css1jUmop5JAl83NirZj1QLxi/fJfp0J+hZGFGgSUbXhIuZTHJaIwDN+mJJBZHX1dNEm/9A0Z fqG9dOSb/iRs/lCjpgIUapBdjyFnncoJRSd4IYa4+GZdcKgGy0y0FhjqN1j+by+Xh3v+Mb/az 2Fp1JcPdHrdl9r0BPXwZILUipN/CVpvA2GnVFKLzyl3IVchrwgnpywl26Ub1ozFk9870KqII6 mr+J1e9Vn+oprNFLYhnrjXwgEQrdaOFQRfFZZcUKJGCH5z+y65e8/D9jgom25ad7a0b1h0n+0 trtDJ/RJk5KVc35VpcEwgGgtOqKDqgA319QtckZrEJ95eF/MTiHvJ5kc/mfTxAFqKdm78USIk SbVICRsIoDReBgOwKXwyj+Lwpt0c72H80x5zly2r5us7xWo0xJFOisQC3KHUryrrPzSxBgV7T quXPnNoEXSq42YKnKXv9k4A0o58ZqGalXkcKXMtduBNUZwbnQS5LjUDTI6oMZeyYhs9D23Wp8 G7eDT/DwH855+cQTzwhlCdGQHRSfJrN+k4hEFKh+wvM6cLXL8QFgOjZRUAuOZ/0MABg7iv2xz szk5NswZocV0aae4yQwXbOxYd7UUbu9+Hg6Ajcnk5lMinacUr3Wu3wOrAO+QqCaiQauQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A compiler warning points out a typo: drivers/pinctrl/pinctrl-rza1.c: In function 'rza1_pinctrl_probe': drivers/pinctrl/pinctrl-rza1.c:1260:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] This changes the condition to the usual check for failure of the previous function call. Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") Signed-off-by: Arnd Bergmann --- drivers/pinctrl/pinctrl-rza1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c index 614a043f3038..1d57d4480a02 100644 --- a/drivers/pinctrl/pinctrl-rza1.c +++ b/drivers/pinctrl/pinctrl-rza1.c @@ -1257,7 +1257,7 @@ static int rza1_pinctrl_probe(struct platform_device *pdev) rza1_pctl->dev = &pdev->dev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (ret) + if (!res) return -ENODEV; rza1_pctl->base = devm_ioremap_resource(&pdev->dev, res); -- 2.9.0