From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbdF3Wy6 (ORCPT ); Fri, 30 Jun 2017 18:54:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:57972 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751370AbdF3Wy5 (ORCPT ); Fri, 30 Jun 2017 18:54:57 -0400 Date: Sat, 1 Jul 2017 00:54:55 +0200 From: "Luis R. Rodriguez" To: Arnd Bergmann Cc: Andrew Morton , "Luis R. Rodriguez" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kmod: add dependencies for test module Message-ID: <20170630225455.GX21846@wotan.suse.de> References: <20170630154834.3689272-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170630154834.3689272-1-arnd@arndb.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 30, 2017 at 05:47:44PM +0200, Arnd Bergmann wrote: > When we try to 'select' drivers whose dependencies are not met, > we get a kconfig warning and undefined behavior as further 'select' > statements in those drivers can not be honored: > > warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET) > warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF)) > ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined! > ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined! > ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined! > > To work around that, this adds the dependencies required by the > 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing > that we can always enable those, and fixing the 'randconfig' issues. > > Unfortunately, there is another problem that I have not found a > good solution for: If any of the three drivers are built-in rather > than loadable modules, then the module load test will later fail > at runtime. > > Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader") > Signed-off-by: Arnd Bergmann Acked-by: Luis R. Rodriguez Luis