From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbdGCGUn (ORCPT ); Mon, 3 Jul 2017 02:20:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58848 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbdGCGUk (ORCPT ); Mon, 3 Jul 2017 02:20:40 -0400 Date: Mon, 3 Jul 2017 08:20:40 +0200 From: Greg KH To: Lynn Lei Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence Message-ID: <20170703062040.GB13523@kroah.com> References: <20170702144033.GA5784@lynnl.wit> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170702144033.GA5784@lynnl.wit> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 02, 2017 at 10:40:33PM +0800, Lynn Lei wrote: > include PANEL_DISPLAY_CTRL_FPVDDEN control mask Does the subject match this? > Signed-off-by: Lynn Lei > --- > drivers/staging/sm750fb/ddk750_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c > index 0f666dc2729a..c68367e6cdeb 100644 > --- a/drivers/staging/sm750fb/ddk750_display.c > +++ b/drivers/staging/sm750fb/ddk750_display.c > @@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay) > u32 reg; > u32 opt[] = { > PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA, > - PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN, > + PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN, Are you sure this is allowed? Why is this patch correct? And again, it doesn't match the subject line :( greg k-h