From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752645AbdGCG7l (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Jul 2017 02:59:41 -0400
Received: from mga07.intel.com ([134.134.136.100]:46161 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752390AbdGCG7k (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Jul 2017 02:59:40 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,301,1496127600"; 
   d="scan'208";a="1147225879"
Date: Mon, 3 Jul 2017 09:59:34 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guenter Roeck <linux@roeck-us.net>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: include linux/device.h in ucsi.h
Message-ID: <20170703065934.GA9509@kuha.fi.intel.com>
References: <20170630154655.3645961-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170630154655.3645961-1-arnd@arndb.de>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 30, 2017 at 05:46:16PM +0200, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
> 
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
>                  from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This includes the required header file.
> 
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
>  #define __DRIVER_USB_TYPEC_UCSI_H
>  
>  #include <linux/bitops.h>
> +#include <linux/device.h>
>  #include <linux/types.h>
>  
>  /* -------------------------------------------------------------------------- */
> -- 
> 2.9.0

-- 
heikki