From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754523AbdGCNTm (ORCPT ); Mon, 3 Jul 2017 09:19:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:57024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754498AbdGCNTj (ORCPT ); Mon, 3 Jul 2017 09:19:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9207D22BDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 3 Jul 2017 09:19:36 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org Subject: Re: [PATCH 2/2] selftests: ftrace: Add more verbosity for immediate log Message-ID: <20170703091936.339ce3db@gandalf.local.home> In-Reply-To: <149905959055.7034.15574100429908289883.stgit@devbox> References: <149905952585.7034.11055785140886204138.stgit@devbox> <149905959055.7034.15574100429908289883.stgit@devbox> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Jul 2017 14:26:40 +0900 Masami Hiramatsu wrote: > Add 3-level verbosity for showing traced command log > on console immediately. Since some test cases can cause > kernel pacic if there is a probrem (like regression etc.), > we can not know which command caused the problem without > traced command log. This verbosity (-vvv) solves that > because it shows the log on console immediately. User > can get continuous command/error log. > > Note that this is a kind of kernel debug mode, if you > don't see any kernel related issue, you don't need this > verbosity. > > Signed-off-by: Masami Hiramatsu > --- > tools/testing/selftests/ftrace/ftracetest | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 290cd42..e3f1521 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -15,6 +15,7 @@ echo " -h|--help Show help message" > echo " -k|--keep Keep passed test logs" > echo " -v|--verbose Increase verbosity of test messages" > echo " -vv Alias of -v -v (Show all results in stdout)" > +echo " -vvv Alias of -v -v -v (Show all commands immediately)" > echo " -d|--debug Debug mode (trace all shell commands)" > echo " -l|--logdir Save logs on the " > exit $1 > @@ -56,9 +57,10 @@ parse_opts() { # opts > KEEP_LOG=1 > shift 1 > ;; > - --verbose|-v|-vv) > + --verbose|-v|-vv|-vvv) > VERBOSE=$((VERBOSE + 1)) > [ $1 = '-vv' ] && VERBOSE=$((VERBOSE + 1)) > + [ $1 = '-vvv' ] && VERBOSE=$((VERBOSE + 2)) > shift 1 > ;; > --debug|-d) > @@ -252,7 +254,9 @@ run_test() { # testfile > testcase $1 > echo "execute$INSTANCE: "$1 > $testlog > SIG_RESULT=0 > - if [ $VERBOSE -ge 2 ]; then > + if [ $VERBOSE -ge 3 ]; then > + __run_test $1 | tee -a $testlog 2>&1 I have nothing against this patch, but I want to point out that the above is far from printing everything out immediately. The tee command buffers a bit. At least it has for me in the past. If the kernel does crash, one needs to still be a bit weary of where exactly the crash happened. Perhaps we need an option to print not to a log, but just let the test print out directly? -- Steve > + elif [ $VERBOSE -eq 2 ]; then > __run_test $1 2>> $testlog | tee -a $testlog > else > __run_test $1 >> $testlog 2>&1