From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbdGCP7M (ORCPT ); Mon, 3 Jul 2017 11:59:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:52440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753716AbdGCP7J (ORCPT ); Mon, 3 Jul 2017 11:59:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3486522B58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 3 Jul 2017 11:59:06 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org Subject: Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests Message-ID: <20170703115906.6f3b1679@gandalf.local.home> In-Reply-To: <20170704005232.a36903c24da6dad19027e12f@kernel.org> References: <149905952585.7034.11055785140886204138.stgit@devbox> <20170703091543.66f6198a@gandalf.local.home> <20170704005232.a36903c24da6dad19027e12f@kernel.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Jul 2017 00:52:32 +0900 Masami Hiramatsu wrote: > > > > > Can we add an option in kselftest, or to ftracetest that decides if > > unsupported is a failure or not? Otherwise I can not ack this patch. > > I would rather like to add an option to ftracetest instead of > kselftest, because whether the tested feature should be supported > or not is hard to decide from testing framework. It should be > checked by manual. Can we do both? That is, add an option to have ftracetest not fail on "unsupported" but have it fail by default. We can have kselftest just pass in a parameter to ftracetest that has unsupported not fail? But if that is too difficult, then I can live with modifying my test case to add the option. -- Steve