From: David Miller <davem@davemloft.net>
To: eduval@amazon.com
Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak
Date: Tue, 04 Jul 2017 01:48:42 -0700 (PDT) [thread overview]
Message-ID: <20170704.014842.1942928249505987408.davem@davemloft.net> (raw)
In-Reply-To: <1499101594-22421-1-git-send-email-eduval@amazon.com>
From: Eduardo Valentin <eduval@amazon.com>
Date: Mon, 3 Jul 2017 10:06:34 -0700
> We currently get the following kmemleak report:
...
> This patch flags the complete_info ptr object as not a leak as it will
> get freed when .complete_priv() is called,
We don't call .complete_priv(). We call .complete().
for the br mdb case, it
> will be freed at br_mdb_complete().
>
> Cc: stable <stable@vger.kernel.org> # v4.9+
> Reviewed-by: Vallish Vaidyeshwara <vallish@amazon.com>
> Signed-off-by: Eduardo Valentin <eduval@amazon.com>
I don't understand why kmemleak cannot see this.
We store the pointer globally when we do the switchdev_port_obv_add()
call and it should be able to see that.
next prev parent reply other threads:[~2017-07-04 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 17:06 Eduardo Valentin
2017-07-04 8:48 ` David Miller [this message]
2017-07-05 16:05 ` Eduardo Valentin
2017-07-11 21:43 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704.014842.1942928249505987408.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=eduval@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®