From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbdGDAaL (ORCPT ); Mon, 3 Jul 2017 20:30:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:40588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdGDAaK (ORCPT ); Mon, 3 Jul 2017 20:30:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BE7522BCC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Tue, 4 Jul 2017 09:30:06 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org Subject: Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests Message-Id: <20170704093006.a4c82ae49fe1660f7e19e075@kernel.org> In-Reply-To: <20170703115906.6f3b1679@gandalf.local.home> References: <149905952585.7034.11055785140886204138.stgit@devbox> <20170703091543.66f6198a@gandalf.local.home> <20170704005232.a36903c24da6dad19027e12f@kernel.org> <20170703115906.6f3b1679@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Jul 2017 11:59:06 -0400 Steven Rostedt wrote: > On Tue, 4 Jul 2017 00:52:32 +0900 > Masami Hiramatsu wrote: > > > > > > > > Can we add an option in kselftest, or to ftracetest that decides if > > > unsupported is a failure or not? Otherwise I can not ack this patch. > > > > I would rather like to add an option to ftracetest instead of > > kselftest, because whether the tested feature should be supported > > or not is hard to decide from testing framework. It should be > > checked by manual. > > Can we do both? That is, add an option to have ftracetest not fail on > "unsupported" but have it fail by default. We can have kselftest just > pass in a parameter to ftracetest that has unsupported not fail? I rather like to treat unsupported as success (or XFAIL) by default and add "--fail-unsupported" option. Thank you, > But if that is too difficult, then I can live with modifying my test > case to add the option. > > -- Steve -- Masami Hiramatsu