From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbdGDLH3 (ORCPT ); Tue, 4 Jul 2017 07:07:29 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50776 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbdGDLH2 (ORCPT ); Tue, 4 Jul 2017 07:07:28 -0400 Date: Tue, 4 Jul 2017 13:07:22 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: Ingo Molnar , linux-kernel , Dietmar Eggemann , Morten Rasmussen Subject: Re: [PATCH v2] sched/pelt: fix false running accounting Message-ID: <20170704110722.jjne2fio5f4gtnwm@hirez.programming.kicks-ass.net> References: <1498831118-22672-1-git-send-email-vincent.guittot@linaro.org> <1498885573-18984-1-git-send-email-vincent.guittot@linaro.org> <20170704072707.sft22eph26p5v5og@hirez.programming.kicks-ass.net> <20170704083405.piubjvketldt5vr7@hirez.programming.kicks-ass.net> <20170704094425.dj5cfpg6iqbe567q@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 04, 2017 at 11:57:12AM +0200, Vincent Guittot wrote: > On 4 July 2017 at 11:44, Peter Zijlstra wrote: > > But but but, how can that happen? Should it not all be under the same > > rq->lock and thus have only a single update_rq_clock() and thus be at > > the same 'instant' ? > > idle_balance() unlock rq->lock before calling update_blocked_averages > And update_blocked_averages() starts by calling update_rq_clock() Ah indeed. Might want to clarify that point.