mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Ben Mezger <su@seds.nl>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] block/Kconfig.iosched: Enable BFQ on DEFAULT_IOSCHED
Date: Tue, 4 Jul 2017 12:34:59 -0700	[thread overview]
Message-ID: <20170704193459.GA6360@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <26128c0d-7607-05e7-acb3-4a52139c232d@seds.nl>

On Tue, Jul 04, 2017 at 01:35:18PM -0300, Ben Mezger wrote:
> This patch, allows BFQ to be chosen in the Default I/O scheduler prompt.

Nak, this doesn't work. The default scheduler Kconfig option is for the
legacy block path, but BFQ is a blk-mq scheduler.

> Signed-off-by: Ben Mezger <me@benmezger.nl>
> ---
>  block/Kconfig.iosched | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched
> index fd2cefa47d35..5be248ce447c 100644
> --- a/block/Kconfig.iosched
> +++ b/block/Kconfig.iosched
> @@ -56,6 +56,9 @@ choice
>         config DEFAULT_NOOP
>                 bool "No-op"
> 
> +       config DEFAULT_BFQ
> +               bool "BFQ" if IOSCHED_BFQ=y
> +
>  endchoice
> 
>  config DEFAULT_IOSCHED
> @@ -63,6 +66,7 @@ config DEFAULT_IOSCHED
>         default "deadline" if DEFAULT_DEADLINE
>         default "cfq" if DEFAULT_CFQ
>         default "noop" if DEFAULT_NOOP
> +       default "bfq" if DEFAULT_BFQ
> 
>  config MQ_IOSCHED_DEADLINE
>         tristate "MQ deadline I/O scheduler"
> --
> 2.13.2
> 
> -- 
> - seds
> https://seds.nl
> 

      reply	other threads:[~2017-07-04 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 16:35 Ben Mezger
2017-07-04 19:34 ` Omar Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704193459.GA6360@vader.DHCP.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=su@seds.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®