From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752319AbdGEBkU (ORCPT ); Tue, 4 Jul 2017 21:40:20 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:33864 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbdGEBkT (ORCPT ); Tue, 4 Jul 2017 21:40:19 -0400 From: Joseph Wright To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joseph Wright Subject: [PATCH] Staging: android/ion: fix sparse warnings Date: Wed, 5 Jul 2017 00:12:24 +0000 Message-Id: <20170705001224.13213-1-rjosephwright@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \ was not declared. Should it be static? ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \ was not declared. Should it be static? ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright --- drivers/staging/android/ion/ion.h | 4 ++++ drivers/staging/android/ion/ion_cma_heap.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index fa9ed81..fda1e91 100644 --- a/drivers/staging/android/ion/ion.h +++ b/drivers/staging/android/ion/ion.h @@ -358,4 +358,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); int ion_query_heaps(struct ion_heap_query *query); +struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data); + +struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data); + #endif /* _ION_H */ diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index a0949bc..c6db9b7 100644 --- a/drivers/staging/android/ion/ion_cma_heap.c +++ b/drivers/staging/android/ion/ion_cma_heap.c @@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma) return &cma_heap->heap; } -int __ion_add_cma_heaps(struct cma *cma, void *data) +static int __ion_add_cma_heaps(struct cma *cma, void *data) { struct ion_heap *heap; -- 2.9.3