From: Tomasz Figa <tfiga@chromium.org>
To: iommu@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
Mitchel Humpherys <mitchelh@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Tomasz Figa <tfiga@chromium.org>
Subject: [RFC PATCH 5/5] iommu/dma: Add iommu_dma_cleanup()
Date: Wed, 5 Jul 2017 16:12:15 +0900 [thread overview]
Message-ID: <20170705071215.17603-6-tfiga@chromium.org> (raw)
In-Reply-To: <20170705071215.17603-1-tfiga@chromium.org>
In case of loadable modules using dma-iommu helpers, it makes sense to
drop the reference to the iova cache on module exit. Add a helper called
iommu_dma_cleanup() that undoes the effects of iommu_dma_init(), so that
modules can be unloaded cleanly.
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
---
drivers/iommu/dma-iommu.c | 6 ++++++
include/linux/dma-iommu.h | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
index 7cdeaf930106..51afa18a5de1 100644
--- a/drivers/iommu/dma-iommu.c
+++ b/drivers/iommu/dma-iommu.c
@@ -82,6 +82,12 @@ int iommu_dma_init(void)
}
EXPORT_SYMBOL(iommu_dma_init);
+void iommu_dma_cleanup(void)
+{
+ iova_cache_put();
+}
+EXPORT_SYMBOL(iommu_dma_cleanup);
+
/**
* iommu_get_dma_cookie - Acquire DMA-API resources for a domain
* @domain: IOMMU domain to prepare for DMA-API usage
diff --git a/include/linux/dma-iommu.h b/include/linux/dma-iommu.h
index 92f20832fd28..b12d9207a87a 100644
--- a/include/linux/dma-iommu.h
+++ b/include/linux/dma-iommu.h
@@ -24,7 +24,9 @@
#include <linux/iommu.h>
#include <linux/msi.h>
+/* Framework initialization - reference counted */
int iommu_dma_init(void);
+void iommu_dma_cleanup(void);
/* Domain management interface for IOMMU drivers */
int iommu_get_dma_cookie(struct iommu_domain *domain);
@@ -85,6 +87,10 @@ static inline int iommu_dma_init(void)
return 0;
}
+static inline void iommu_dma_cleanup(void)
+{
+}
+
static inline int iommu_get_dma_cookie(struct iommu_domain *domain)
{
return -ENODEV;
--
2.13.2.725.g09c95d1e9-goog
prev parent reply other threads:[~2017-07-05 7:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 7:12 [RFC PATCH 0/5] Fixes for loadable modules implementing DMA/IOMMU APIs Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols Tomasz Figa
2017-07-05 15:17 ` Christoph Hellwig
2017-07-05 15:22 ` Tomasz Figa
2017-07-05 17:20 ` Christoph Hellwig
2017-07-06 1:44 ` Tomasz Figa
2017-07-06 8:26 ` Arnd Bergmann
2017-07-06 8:34 ` Tomasz Figa
2017-07-06 8:36 ` Tomasz Figa
2017-07-06 12:23 ` Arnd Bergmann
2017-07-06 13:31 ` Tomasz Figa
2017-07-06 13:49 ` Tomasz Figa
2017-07-06 14:02 ` Arnd Bergmann
2017-07-06 14:06 ` Tomasz Figa
2017-07-06 14:27 ` Arnd Bergmann
2017-07-06 14:35 ` Tomasz Figa
2017-07-06 13:56 ` Arnd Bergmann
2017-07-05 7:12 ` [RFC PATCH 2/5] base: dma-mapping: Provide a function to look up remapped pages Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 3/5] iommu: Export non-static functions to use in modules Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 4/5] iommu/dma: " Tomasz Figa
2017-07-05 16:22 ` Robin Murphy
2017-07-06 2:25 ` Tomasz Figa
2017-07-06 11:09 ` Robin Murphy
2017-07-06 14:10 ` Christoph Hellwig
2017-07-06 14:17 ` Tomasz Figa
2017-07-06 14:24 ` Tomasz Figa
2017-07-06 14:35 ` Arnd Bergmann
2017-07-06 14:41 ` Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705071215.17603-6-tfiga@chromium.org \
--to=tfiga@chromium.org \
--cc=arnd@arndb.de \
--cc=egtvedt@samfundet.no \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mitchelh@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®