From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbdGELHa (ORCPT ); Wed, 5 Jul 2017 07:07:30 -0400 Received: from mx.redlab-i.ru ([195.16.34.155]:36450 "EHLO mail.redlab-i.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755AbdGELH3 (ORCPT ); Wed, 5 Jul 2017 07:07:29 -0400 X-Spam-ASN: Date: Wed, 5 Jul 2017 14:07:23 +0300 From: Alexander Gerasiov To: Alan Cox Cc: Sudip Mukherjee , Andy Shevchenko , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card. Message-ID: <20170705140723.709d9c51@brick.gerasiov.net> In-Reply-To: <20170619193734.08f1697f@alans-desktop> References: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> <20170618213748.28e312c6@brick.gerasiov.net> <20170618210659.GA3785@sudip-laptop> <20170619193734.08f1697f@alans-desktop> Organization: REDLAB-I LLC X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alan, On Mon, 19 Jun 2017 19:37:34 +0100 Alan Cox wrote: > On Sun, 18 Jun 2017 22:06:59 +0100 > Sudip Mukherjee wrote: > > > On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov > > wrote: > > > Hello Andy, > > > > > > While preparing the update I suddenly found, that > > > parport_serial.c is not the right place for this card. Since > > > there is no serial ports on the board, it would be better to put > > > it into parport_pc.c > > > > Yes, that will be better. Thanks. > > Are the uarts physically present but the connector unwired, or are > they not detectable at all ? > > If it's the former then can you add a comment in parport_serial.c > giving the ID and explaining why it's not present, even if you put > the code into parport_pc. According to http://wiki.linuxcnc.org/cgi-bin/wiki.pl?WCH the chip itself does not differ from one in card with dev-id 3253. So technically one can solder connectors and use this card as 2serial + 1parallel. But he could also remove link between pins 62 and 63 and get the board indentified as 3252. So, I believe, it would be less confusing (for users) if we do not create serial devices for this adapter. -- Best regards, Alexander Gerasiov Contacts: e-mail: gq@cs.msu.su Homepage: http://gerasiov.net Skype: gerasiov PGP fingerprint: 04B5 9D90 DF7C C2AB CD49 BAEA CA87 E9E8 2AAC 33F1