From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbdGEPY3 (ORCPT ); Wed, 5 Jul 2017 11:24:29 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:53045 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbdGEPY0 (ORCPT ); Wed, 5 Jul 2017 11:24:26 -0400 X-IronPort-AV: E=Sophos;i="5.40,312,1496127600"; d="scan'208";a="1960071" Date: Wed, 5 Jul 2017 17:23:43 +0200 From: Ludovic Desroches To: Claudiu Beznea CC: , , , , , , , , , Subject: Re: [PATCH v2 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support Message-ID: <20170705152343.b735on6edg3vfsp3@rfolt0960.corp.atmel.com> Mail-Followup-To: Claudiu Beznea , nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, sza@esh.hu, devicetree@vger.kernel.org, cristian.birsan@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1499086572-6083-1-git-send-email-claudiu.beznea@microchip.com> <1499086572-6083-5-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1499086572-6083-5-git-send-email-claudiu.beznea@microchip.com> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 03, 2017 at 03:56:11PM +0300, Claudiu Beznea wrote: > Add specific DTS file and bindings for sama5d27 SoM1 board. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > --- > arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 178 ++++++++++++++++++++++++++++++ > 1 file changed, 178 insertions(+) > create mode 100644 arch/arm/boot/dts/at91-sama5d27_som1.dtsi > > diff --git a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi > new file mode 100644 > index 0000000..c3a1dc8 > --- /dev/null > +++ b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi [...] > + > + i2c0: i2c@f8028000 { > + dmas = <0>, <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c0_default>; > + i2c-sda-hold-time-ns = <350>; > + status = "disabled"; > + > + 24aa@50 { > + compatible = "24mac602"; > + reg = <0x50>; > + pagesize = <8>; > + start-offset = /bits/ 8 <0xf8>; Are you sure about the offset? I thought it was 0xfa but maybe I am wrong. Regards Ludovic