From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728AbdGEPhc (ORCPT ); Wed, 5 Jul 2017 11:37:32 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58939 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbdGEPhb (ORCPT ); Wed, 5 Jul 2017 11:37:31 -0400 Date: Wed, 5 Jul 2017 17:37:25 +0200 From: Peter Zijlstra To: Greg Kroah-Hartman Cc: Kees Cook , Ingo Molnar , "Jason A. Donenfeld" , Thomas Hellstrom , Andi Kleen , Daniel Micay , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kref: Avoid null pointer dereference after WARN Message-ID: <20170705153725.4nmdezykcz3b7ped@hirez.programming.kicks-ass.net> References: <20170627035215.GA132342@beast> <20170627070626.GH29909@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627070626.GH29909@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2017 at 09:06:26AM +0200, Greg Kroah-Hartman wrote: > > I remember one complaint was that WARN_ON was "huge" and this bloated > the kernel code a lot. But then that got fixed up. Is BUG_ON going to > cause the same complaint again? BUG_ON and WARN_ON should be of equal (small) size.