From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbdGEViG (ORCPT ); Wed, 5 Jul 2017 17:38:06 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:37544 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbdGEViE (ORCPT ); Wed, 5 Jul 2017 17:38:04 -0400 Date: Wed, 5 Jul 2017 23:37:46 +0200 From: Alexandre Belloni To: Amelie Delaunay Cc: Alessandro Zummo , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre Torgue , rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support Message-ID: <20170705213746.6hf5af57ty6wsfgs@piout.net> References: <1498470689-26829-1-git-send-email-amelie.delaunay@st.com> <1498470689-26829-3-git-send-email-amelie.delaunay@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498470689-26829-3-git-send-email-amelie.delaunay@st.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is mostly fine, even if I'm not too happy with the s/ck_rtc/rtc_ck/. On 26/06/2017 at 11:51:29 +0200, Amelie Delaunay wrote: > - rtc->ck_rtc = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(rtc->ck_rtc)) { > - dev_err(&pdev->dev, "no ck_rtc clock"); > - return PTR_ERR(rtc->ck_rtc); > + match = of_match_device(stm32_rtc_of_match, &pdev->dev); > + if (match && match->data) > + rtc->data = (struct stm32_rtc_data *)match->data; > + else > + return -EINVAL; This will never happen, you can remove that test. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com