From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Re: [PATCH] PM / devfreq: constify attribute_group structures.
Date: Thu, 06 Jul 2017 01:39:47 +0000 [thread overview]
Message-ID: <20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d@epcms1p3> (raw)
In-Reply-To: <595A19AA.3060105@samsung.com>
> On 2017년 07월 03일 19:10, Arvind Yadav wrote:
> > attribute_groups are not supposed to change at runtime. All functions
> > working with attribute_groups provided by <linux/sysfs.h> work with const
> > attribute_group. So mark the non-const structs as const.
> >
> > File size before:
> > text data bss dec hex filename
> > 621 176 0 797 31d drivers/devfreq/governor_userspace.o
> >
> > File size After adding 'const':
> > text data bss dec hex filename
> > 670 144 0 814 32e drivers/devfreq/governor_userspace.o
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/devfreq/governor_userspace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
[]
>
> Looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Thank you. Applying to for-rc branch.
Cheers,
MyungJoo
prev parent reply other threads:[~2017-07-06 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170703101025epcas4p151a0c496ae3410031c27f4da7ab9714f@epcas4p1.samsung.com>
2017-07-03 10:10 ` Arvind Yadav
2017-07-03 10:17 ` Chanwoo Choi
[not found] ` <CGME20170703101025epcas4p151a0c496ae3410031c27f4da7ab9714f@epcms1p3>
2017-07-06 1:39 ` MyungJoo Ham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d@epcms1p3 \
--to=myungjoo.ham@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®