mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH] timekeeping: Use proper timekeeper for debug code
Date: Thu, 6 Jul 2017 12:58:55 +0900	[thread overview]
Message-ID: <20170706035855.GA2511@lianli.shorne-pla.net> (raw)
In-Reply-To: <CALAqxLXL9XBO=HZ1Lwt=XW9FnFMvnXw8dn5bFb7_XcUFJgJUCA@mail.gmail.com>

Hi tglx,

Sorry, to bother you, I thought maybe this you missed this one?  Let me
know if you want a resend.

-Stafford

On Wed, Jun 28, 2017 at 10:39:21AM -0700, John Stultz wrote:
> On Wed, Jun 28, 2017 at 6:21 AM, Stafford Horne <shorne@gmail.com> wrote:
> > When CONFIG_DEBUG_TIMEKEEPING is enabled the timekeeping_check_update()
> > function will update status like last_warning and underflow_seen on the
> > timekeeper.
> >
> > If there are issues found this state is used to rate limit the warnings
> > that get printed.
> >
> > This rate limiting doesn't really really work if stored in real_tk as
> > the shadow timekeeper is overwritten onto real_tk at the end of every
> > update_wall_time() call, resetting last_warning and other statuses.
> >
> > Fix rate limiting by using the shadow_timekeeper for
> > timekeeping_check_update().
> >
> > Fixes: commit 57d05a93ada7 ("time: Rework debugging variables so they aren't global")
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> 
> Interesting!  Thanks for submitting this! Out of curiosity, can you
> also talk about the underlying issue that made you come across this
> issue?
> 
> thanks
> -john

  parent reply	other threads:[~2017-07-06  3:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 13:21 Stafford Horne
2017-06-28 17:39 ` John Stultz
2017-06-28 22:31   ` Stafford Horne
2017-07-06  3:58   ` Stafford Horne [this message]
2017-07-06  4:06     ` John Stultz
2017-07-06  4:55       ` Stafford Horne
2017-07-06  5:01         ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706035855.GA2511@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®