From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Niklas Cassel <niklas.cassel@axis.com>,
stable@vger.kernel.org, torvalds@linux-foundation.org,
tglx@linutronix.de, ktkhai@virtuozzo.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in __down_write_common()
Date: Thu, 6 Jul 2017 09:42:34 +0200 [thread overview]
Message-ID: <20170706074234.ulpvtse7s2qtdwgx@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170706072858.yo45chbf6fnccmgw@gmail.com>
On Thu, Jul 06, 2017 at 09:28:58AM +0200, Ingo Molnar wrote:
> It's more straightforward to just do the canonical sem->count >= 0 test that we do
> elsewhere in the rwsem-spinlock code.
>
> PeterZ, what's your preference?
Leave it as is.. it doesn't matter (the 0 case shouldn't happen) and as
you say >= 0 is what most other code does.
prev parent reply other threads:[~2017-07-06 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 13:44 [PATCH] rwsem-spinlock: " Kirill Tkhai
2017-06-28 13:20 ` Niklas Cassel
2017-06-28 15:36 ` Kirill Tkhai
2017-07-05 14:27 ` [tip:locking/urgent] locking/rwsem-spinlock: " tip-bot for Kirill Tkhai
2017-07-05 14:45 ` Niklas Cassel
2017-07-06 7:28 ` Ingo Molnar
2017-07-06 7:42 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706074234.ulpvtse7s2qtdwgx@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=niklas.cassel@axis.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®