mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev@vger.kernel.org, Ivan Delalande <colona@arista.com>,
	"David S. Miller" <davem@davemloft.net>,
	Bob Gilligan <gilligan@arista.com>, Eric Mowat <mowat@arista.com>
Subject: Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static
Date: Thu, 6 Jul 2017 10:27:12 +1000	[thread overview]
Message-ID: <20170706102712.3904c199@canb.auug.org.au> (raw)
In-Reply-To: <20170705235853.GA69361@lkp-sb04.lkp.intel.com>

Hi,

Not sure why you sent this to me ... it fixes a commit in the net-next
tree (now in Linus' tree) ...

On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>
> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")

Actually:  Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")

> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  tcp_ipv4.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 6ec6900..a20e7f0 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
>  }
>  EXPORT_SYMBOL(tcp_md5_do_lookup);
>  
> -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> -					       const union tcp_md5_addr *addr,
> -					       int family, u8 prefixlen)
> +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> +						      const union tcp_md5_addr *addr,
> +						      int family, u8 prefixlen)
>  {
>  	const struct tcp_sock *tp = tcp_sk(sk);
>  	struct tcp_md5sig_key *key;

-- 
Cheers,
Stephen Rothwell

  reply	other threads:[~2017-07-06  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 23:58 net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static? kbuild test robot
2017-07-05 23:58 ` [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static kbuild test robot
2017-07-06  0:27   ` Stephen Rothwell [this message]
2017-07-06  8:57     ` Fengguang Wu
2017-07-06  9:55     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706102712.3904c199@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=colona@arista.com \
    --cc=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=gilligan@arista.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kbuild-all@01.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mowat@arista.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®