From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbdGFUrk (ORCPT ); Thu, 6 Jul 2017 16:47:40 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35593 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdGFUrj (ORCPT ); Thu, 6 Jul 2017 16:47:39 -0400 Date: Thu, 6 Jul 2017 22:46:46 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Linus Walleij , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Message-ID: <20170706204646.3akr57fo6c2ok4wn@flea> References: <20170706142822.20296-1-icenowy@aosc.io> <20170706142822.20296-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lia4rf3fybgly4n3" Content-Disposition: inline In-Reply-To: <20170706142822.20296-2-icenowy@aosc.io> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lia4rf3fybgly4n3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: > The PH16 pin has a function with mux id 0x5, which is the DET pin of the > "sim" (smart card reader) IP block. >=20 > This function is missing both in the old A10 and A20 drivers, so it's > not found during the merge of these two drivers. >=20 > Add it to the driver. As we now merged A20 pinctrl driver to the A10 > one, we need to only fix the A10 driver now. >=20 > Signed-off-by: Icenowy Zheng I'm not sure what you mean there. It's not mentionned in the A10 datasheet, and neither in the A20. Where did you get that info from? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --lia4rf3fybgly4n3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZXqG2AAoJEBx+YmzsjxAgRisP/1okMnXqczPsb2veN0NBnGdv wRE3ezOHnbvADVASkDUevA/3JtrOoVAoWoqCNz7xrqb/S8NHAm3AT+qJGiTw/BvS cX/r6elRnF5/VRHeCwvKLGJY8JJ86qhP+Xm7c0Dqu7MGMMG9aI9Oo1G2/0nuZhS7 xrZQQZj2wx99qQDGtjZNkM9j0rGcLWQS+ybS0gGRAJge4FCaNtfw/HybgvDsZYrr rRBOLOE5Y5ZHi+euX2+IcnMZFDkDO+nYoAPcfCjaOQyrMyHrzHwDkJ6V4E4Yk5JC NTfy/oWvOrRFMqF3B+eT/9sEGT9xDJBcWPUmcePVskcELuml1uiR0q3yDNZPOkjy 5hm7lSuoUAdZPSHQYZn8xo+5Uozjn2bQ6C+xWD49fjDZqxMsxZVAH8dUbXbdWzBe ao1bnyBzjIb1HLu33HLmZ4hjrn3ugcmGdmigXLy85tW4LGokJc5eU3//pwsEgF0F Ms/jSh69WWAu3do3RiuO5YkNPftUfa1vKTQdPzqvbgW/RIa0aVl0FxBYGQrXzteD 1einyEZqCGEkFLDDS5KFnejA3+0zQxBXadXsZ0mU5sgCZVv+WNNV+NB8OB7K9Ftu LhBn3PMJP/jgRhuoYnoUT3sIozaq4drAHmC++sycyO559qJrFcg+Ek1iEJDIXw/A DSa7WGx8pcgfRLSagxXW =vZ67 -----END PGP SIGNATURE----- --lia4rf3fybgly4n3--