mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/3] lib/test_kmod: take the lock in register_test_dev_kmod()
Date: Fri, 7 Jul 2017 11:40:36 +0300	[thread overview]
Message-ID: <20170707084036.f6jxmffxk67qtmce@mwanda> (raw)
In-Reply-To: <20170707083933.2mgnpqafhspbwu7h@mwanda>

We accidentally just drop the lock twice instead of taking it and then
releasing it.

Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 8797400b8bda..093b44771197 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1146,7 +1146,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
 	struct kmod_test_device *test_dev = NULL;
 	int ret;
 
-	mutex_unlock(&reg_dev_mutex);
+	mutex_lock(&reg_dev_mutex);
 
 	/* int should suffice for number of devices, test for wrap */
 	if (unlikely(num_test_devs + 1) < 0) {

  reply	other threads:[~2017-07-07  8:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  8:39 [PATCH 1/3] lib/test_kmod: tidy up bounds checking Dan Carpenter
2017-07-07  8:40 ` Dan Carpenter [this message]
2017-08-01 23:16   ` [PATCH 2/3] lib/test_kmod: take the lock in register_test_dev_kmod() Luis R. Rodriguez
2017-07-07  8:41 ` [PATCH 3/3] lib/test_kmod: fix fs module tests Dan Carpenter
2017-08-01 23:19   ` Luis R. Rodriguez
2017-08-01 23:10 ` [PATCH 1/3] lib/test_kmod: tidy up bounds checking Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707084036.f6jxmffxk67qtmce@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®