From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbdGGWuV (ORCPT ); Fri, 7 Jul 2017 18:50:21 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:34302 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbdGGWuT (ORCPT ); Fri, 7 Jul 2017 18:50:19 -0400 Date: Fri, 7 Jul 2017 23:50:14 +0100 From: Lee Jones To: Linus Torvalds Cc: Linux Kernel Mailing List Subject: Re: [GIT PULL] MFD for v4.13 Message-ID: <20170707225014.422x5ptpvnqpu674@dell> References: <20170707095013.fa2ik3nqedkeer6t@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Jul 2017, Linus Torvalds wrote: > On Fri, Jul 7, 2017 at 2:50 AM, Lee Jones wrote: > > > > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++ > > So I've pulled everything but this, because honestly, that file looks > like utter garbage. > > Why are there all those _hundreds_ of odd defines for > > MADERA_WSEQ_SEQUENCE_xx > > when it looks like you could just do one single one: > > // The sequence is one-based because somebody doesn't > // know that indices start at 0. Thus the "-2". > #define MADERA_WSEQ_SEQUENCE(x) (0x3000 + (x)*2 - 2) > > and similar things go for for pretty much EVERY SINGLE LINE in that > 8-thousand line piece of nasty horrible crud. > > Being auto-generated doesn't really make this kind of thing any > better. In fact, it makes it worse, because those stupid hardcoded > names are often *harder* to use, because you cannot use a variable to > index into things (which you may often want). > > So we have eight thousand lines of garbage that is > > (a) probably closer to 200x too many lines > (b) less flexible than doing it right > > Honestly, tell me why would I want to merge something monstrous like that? I'm inclined to agree and had my reservations. However based on a previous conversation [0], I was convinced that it's actually the right thing to do. https://lkml.org/lkml/2017/4/7/229 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog