From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbdGJIpL (ORCPT ); Mon, 10 Jul 2017 04:45:11 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:60539 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753659AbdGJIpI (ORCPT ); Mon, 10 Jul 2017 04:45:08 -0400 Date: Mon, 10 Jul 2017 10:44:00 +0200 From: Maxime Ripard To: icenowy@aosc.io Cc: Linus Walleij , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Message-ID: <20170710084400.wwrfjekv2fkoqvoa@flea> References: <20170706142822.20296-1-icenowy@aosc.io> <20170706142822.20296-2-icenowy@aosc.io> <20170706204646.3akr57fo6c2ok4wn@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xwgvccwzumpxs32k" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xwgvccwzumpxs32k Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2017 at 07:21:19AM +0800, icenowy@aosc.io wrote: > =E5=9C=A8 2017-07-07 04:46=EF=BC=8CMaxime Ripard =E5=86=99=E9=81=93=EF=BC= =9A > > Hi, > >=20 > > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: > > > The PH16 pin has a function with mux id 0x5, which is the DET pin of > > > the > > > "sim" (smart card reader) IP block. > > >=20 > > > This function is missing both in the old A10 and A20 drivers, so it's > > > not found during the merge of these two drivers. > > >=20 > > > Add it to the driver. As we now merged A20 pinctrl driver to the A10 > > > one, we need to only fix the A10 driver now. > > >=20 > > > Signed-off-by: Icenowy Zheng > >=20 > > I'm not sure what you mean there. It's not mentionned in the A10 > > datasheet, and neither in the A20. Where did you get that info from? >=20 > It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and > "A20 Datasheet V1.41 20131230.pdf". Mentionning that in the commit log would be great. Where did you find those? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --xwgvccwzumpxs32k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZYz5QAAoJEBx+YmzsjxAgd0MQAK+z1++YYxF8M52D9e6L5PUB yqx9+ccb+R1VZjxZPDfeHJ2WxUQogMd3JTc1/Q0gwPCeJiFhbkRL7pHfZH4QaHaS bZRnlhN+WqQy51Akhf4Uoy7mnsVjqxVXblsjZzmKTjIpi5wqRR25WiWVX61Y3j7p 5S6xNcbOX9Ku2//MI5Ta9pF6vgp8a5lkHosY6u28kO+jgB6lDXiHeoUKTZdZEGYX uVGpbdw9Nlu0MuXvKh84ss691sS2SG+KdTFh+we7MLbW9jjmaHVy6xx4I80xsusC ZFc0vH0OaKcZV5YEikeTREVXHgGJDhVcRz1OWEV7cxlX/n38Q2/24ahMWXJomfNq Gn+/M779vInhIQZMijzFbhnqmLGDTPaU/0oslvlWQ12WvPDslO+mLkauMQfIxZYM vW087YvMK+msI5ulV8FSkFZL0Av5dRotbiUX46UobMt0kfsayVDiSgydN39ox27R Hil8asZqpW0j+kSSPE3TiI+gD9Tcb0rkqC5861YCJ+pe0DOPqzcDhdTvWmIXcU/d A0pR/zglN1zXXWE8LdCT+cbcFsUBvHyOQyB/qeYDiAEDxjGzEJudCxZ1QNeSFZEV nWTZhxpxC2jPcVRNa31t78X7c8PTuzqrnW5UKYt9S1oc1O1TxmFhJhD/jkDPjPHH mHrJo7EOLPvA9JgIQjO+ =tfWg -----END PGP SIGNATURE----- --xwgvccwzumpxs32k--