From: Arnd Bergmann <arnd@arndb.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Eric Van Hensbergen <ericvh@gmail.com>,
Ron Minnich <rminnich@sandia.gov>,
Latchesar Ionkov <lucho@ionkov.net>,
Ingo Molnar <mingo@kernel.org>, Jens Axboe <axboe@fb.com>,
David Howells <dhowells@redhat.com>, Jan Kara <jack@suse.cz>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE
Date: Mon, 10 Jul 2017 13:21:41 +0200 [thread overview]
Message-ID: <20170710112154.940606-1-arnd@arndb.de> (raw)
show_options cannot print this option when it is disabled in Kconfig:
fs/9p/v9fs.c: In function 'v9fs_show_options':
fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?
Fixes: ccb0055985b9 ("9p: Implement show_options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/9p/v9fs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index d69046650a36..8fb89ddc6cc7 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -137,8 +137,10 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root)
seq_puts(m, ",nodevmap");
if (v9ses->cache)
seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
+#ifdef CONFIG_9P_FSCACHE
if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
seq_printf(m, ",cachetag=%s", v9ses->cachetag);
+#endif
switch (v9ses->flags & V9FS_ACCESS_MASK) {
case V9FS_ACCESS_USER:
--
2.9.0
next reply other threads:[~2017-07-10 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 11:21 Arnd Bergmann [this message]
2017-07-11 15:28 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710112154.940606-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=dhowells@redhat.com \
--cc=ericvh@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mingo@kernel.org \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®