From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbdGJM2q (ORCPT ); Mon, 10 Jul 2017 08:28:46 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:37126 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbdGJM2p (ORCPT ); Mon, 10 Jul 2017 08:28:45 -0400 Date: Mon, 10 Jul 2017 14:28:43 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Srinivas Kandagatla , Linux Kernel Mailing List Subject: Re: [PATCH] nvmem: include linux/err.h from header Message-ID: <20170710122843.dxxcr2sdsnxzvf2y@piout.net> References: <20170710112300.958195-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2017 at 14:10:03 +0200, Arnd Bergmann wrote: > On Mon, Jul 10, 2017 at 1:33 PM, Srinivas Kandagatla > wrote: > > > > > > On 10/07/17 12:22, Arnd Bergmann wrote: > >> > >> The new support for nvmem devices from the rtc layer caused a build > >> error in some configurations: > >> > >> include/linux/nvmem-provider.h: In function 'nvmem_register': > >> include/linux/nvmem-provider.h:51:9: error: implicit declaration of > >> function 'ERR_PTR' [-Werror=implicit-function-declaration] > >> > >> This adds the missing include to ensure we can always include > >> the header. > >> > >> Fixes: 697e5a47aa12 ("rtc: add generic nvmem support") > >> Signed-off-by: Arnd Bergmann > >> --- > >> I'd suggest adding this patch in the rtc tree on top of the > >> nvmem support there. > > > > > > Thanks for the patch, we would need similar patch for > > include/linux/nvmem-consumer.h too. > > Makes sense, yes. Can you do that for 4.14? My patch for now is > needed to fix a build regression in the rtc-next tree that I > assume will otherwise make it into the 4.13 release. > Yes, I'm planning to send my PR soon. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com