From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034AbdGJOn1 (ORCPT ); Mon, 10 Jul 2017 10:43:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37212 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbdGJOnZ (ORCPT ); Mon, 10 Jul 2017 10:43:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E3C1D3D94F Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rgb@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E3C1D3D94F Date: Mon, 10 Jul 2017 10:43:09 -0400 From: Richard Guy Briggs To: Paul Moore Cc: Deepa Dinamani , Arnd Bergmann , Mel Gorman , Tony Jones , LKML , linux-audit@redhat.com Subject: Re: [PATCH] audit: Reduce overhead using a coarse clock Message-ID: <20170710144309.GC17720@madcap2.tricolour.ca> References: <20170704121143.rvxkmm4rpphbyfd7@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 10 Jul 2017 14:43:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-07-06 16:25, Paul Moore wrote: > On Tue, Jul 4, 2017 at 3:41 PM, Deepa Dinamani wrote: > > On Tue, Jul 4, 2017 at 12:20 PM, Arnd Bergmann wrote: > >> On Tue, Jul 4, 2017 at 2:11 PM, Mel Gorman wrote: > >>> > >>> Signed-off-by: Mel Gorman > >> > >> Acked-by: Arnd Bergmann > > > > Acked-by: Deepa Dinamani > > > > As already Arnd pointed out, your patch should be fine as that is how > > it was before my patch. Since nobody saw any problems before my patch, > > lower granularity should be fine. > > Agreed. Mel's patch basically restores the previous behavior while > keeping the 64-bit timestamp size. > > Considering where we are at with the merge window, I'm going to merge > this into the audit/next branch and not send this up to Linus during > the current window; while the patch is small, I like to give things > some time in linux-next before sending them up. This looks fine to me. Audit has its own event counter so the slightly coarser granularity of this counter to avoid the overhead shouldn't be a significant problem. Reviewed-by: Richard Guy Briggs > paul moore - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635